Make ASFlags, CFlags, CPPFlags, LDFlags inheritable.#22
Open
StephaneSeyvoz wants to merge 1 commit intoMIND-Tools:masterfrom
Open
Make ASFlags, CFlags, CPPFlags, LDFlags inheritable.#22StephaneSeyvoz wants to merge 1 commit intoMIND-Tools:masterfrom
StephaneSeyvoz wants to merge 1 commit intoMIND-Tools:masterfrom
Conversation
Member
Author
|
We realized that such behavior could lead to issues with multiple inheritance, leading to possible flags conflicts or merge. Since no annotation merge exists, we propose to either :
|
StephaneSeyvoz
force-pushed
the
common-annotations-inheritance
branch
from
2ec71b0 to
12bbc5e
Compare
StephaneSeyvoz
force-pushed
the
common-annotations-inheritance
branch
2 times, most recently
from
cd88ca1 to
3381542
Compare
StephaneSeyvoz
force-pushed
the
common-annotations-inheritance
branch
from
3381542 to
c4147c5
Compare
StephaneSeyvoz
force-pushed
the
common-annotations-inheritance
branch
from
c4147c5 to
87acb1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today, the annotations are not propagated to children types, needing unwanted duplication.
Note: The annotation system, when using inheritance, is already made to override with the children one, as coded in common-frontend/src/main/java/org.ow2.mind.annotation/AnnotationHelper.java#mergeDecoration method.